Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ADDR associated type from native VPs #1725

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Jul 15, 2023

Describe your changes

This PR closes #1724

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@sug0 sug0 requested a review from tzemanovic July 15, 2023 08:14
tzemanovic
tzemanovic previously approved these changes Jul 17, 2023
tzemanovic added a commit that referenced this pull request Jul 18, 2023
* tiago/remove-native-vp-addr:
  changelog: add #1725
  Remove `ADDR` associated type from native VPs
@sug0
Copy link
Contributor Author

sug0 commented Jul 22, 2023

rip, this didn't make it to the release

@tzemanovic
Copy link
Member

rip, this didn't make it to the release

ah, sry! I think I forgot to add it to draft description so we missed it :/

tzemanovic added a commit that referenced this pull request Jul 24, 2023
* tiago/remove-native-vp-addr:
  changelog: add #1725
  Remove `ADDR` associated type from native VPs
@tzemanovic tzemanovic mentioned this pull request Jul 24, 2023
@Fraccaman Fraccaman merged commit 04f2f79 into main Jul 26, 2023
11 of 12 checks passed
@Fraccaman Fraccaman deleted the tiago/remove-native-vp-addr branch July 26, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove native VP ADDR associated type
3 participants